perf: internal objects optimization (BaseAccount, Balance & Supply) #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replaced cdc.(Un)MarshalInterface() with protobuf (Un)Marshal for internal objects: BaseAccount, Balance & Supply * PubKey in BaseAccount has three seperate entries for publick keys to avoid MarshalInterface. * custom json marshaler for BaseAccount to show a single pub key for json compatibility
Codecov Report
@@ Coverage Diff @@
## main #320 +/- ##
=======================================
Coverage ? 53.11%
=======================================
Files ? 642
Lines ? 47570
Branches ? 0
=======================================
Hits ? 25267
Misses ? 19416
Partials ? 2887 |
egonspace
reviewed
Sep 9, 2021
egonspace
reviewed
Sep 9, 2021
|
Let's update |
* fix: treat addresses as strings * fix: compile errors, test failures * fix: works-1 * feat: integrate ostracon * fix: bump up ostracon * fix: lint error * fix: bump up ostracon * fix: self review * fix: modify changelog * fix: disable arm building * fix: bls build failure on arm * fix: bls build failure on arm * fix: bls build failure on arm
|
Updated CHANGELOG |
dudong2
reviewed
Sep 10, 2021
dudong2
approved these changes
Sep 10, 2021
whylee259
reviewed
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal objects: BaseAccount, Balance & Supply
avoid MarshalInterface.
json compatibility
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes